Repository navigation
Conversation
The default console format prints the message and request context but drops metadata, so a relativePath passed as metadata only reached the JSON file log.
berry-13
added
🐛 bug
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#17876 stopped a bundled file removed from a running deployment skill from aborting the batch upload, but the skipped file's name still does not reach the default console. It passes
relativePathas log metadata, and the default console format prints only the message and request context, so Docker stdout showsFailed to get stream:with no file name. It only appears in the JSON file log or withCONSOLE_JSONorDEBUG_CONSOLEon.The name now goes in the message, matching the neighbouring
No download stream for "..."line. This also adds end-to-end coverage of the removed-file path against the fake Code API, which is how the gap was found.Related to #17846, which can be closed by hand once this merges.
Type of change
Testing
Tested environments/configuration:
Mock e2e harness with the fake Code API, on desktop light, desktop dark and mobile. A fixture deployment skill has one bundled file removed while the server runs and restored afterwards.
Automated tests:
npx jest src/skills/__tests__/deployment.test.ts src/agents/skillFiles.spec.ts: 64 of 64 pass, with the log assertion updated to the new message.e2e/specs/mock/scenarios/deployment-skill-removed-file.spec.ts: the remaining files reach the Code API without the removed one, and a raw download answers with a fixed error body that names no path. Both pass in all three projects.Error streaming file.Failed to get stream for "b-removed.txt"on the default console.Screenshots / recordings
No user-facing change
Risk / compatibility
Anything matching the exact old log text needs updating. The new fixture skill is not always-apply, but it does appear in skill lists in the mock harness. A skipped file still does not fail the prime, as described in #17876.
Checklist